-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTFE-672: api authentication #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how I see it according to the example.
Co-authored-by: Thomas Carmet <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 90.27% 91.06% +0.78%
==========================================
Files 17 21 +4
Lines 360 403 +43
==========================================
+ Hits 325 367 +42
- Misses 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Thomas Carmet <[email protected]>
Co-authored-by: Thomas Carmet <[email protected]>
d4430bc
to
c814f6f
Compare
Co-authored-by: Thomas Carmet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It LGTM, left one task that is harder to do speaking about routes, try your best on it, if it doesn't work out of the box leave it as is and we'll re-iterate on it as needed.
Co-authored-by: Thomas Carmet <[email protected]>
No description provided.